Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1631790 transport layer #963

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

SNOW-1631790 transport layer #963

wants to merge 12 commits into from
+221 −48

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Nov 18, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.39326% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (599e55c) to head (8e8998b).

Files with missing lines Patch % Lines
lib/http/base.js 82.97% 8 Missing ⚠️
lib/http/node.js 83.33% 4 Missing ⚠️
lib/connection/connection_config.js 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   88.98%   88.96%   -0.02%     
==========================================
  Files          69       70       +1     
  Lines        6754     6815      +61     
==========================================
+ Hits         6010     6063      +53     
- Misses        744      752       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review November 19, 2024 08:03
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner November 19, 2024 08:03
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Snow 1631790 transport layer SNOW-1631790 transport layer Nov 19, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki mentioned this pull request Nov 21, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fpawlowski @sfc-gh-pmotacki